Applied review remarks

src/bundle/ApiPlatform/ClassNameResourceNameCollectionFactory.php

@@ -16,9 +16,7 @@
  */
 final class ClassNameResourceNameCollectionFactory implements ResourceNameCollectionFactoryInterface
 {
-    /**
-     * @var array<string>
-     */
+    /** @var array<string> */
     private array $resources = [];
 
     public function create(): ResourceNameCollection
@@ -27,7 +25,7 @@ public function create(): ResourceNameCollection
     }
 
     /**
-     * @param array<string> $newResources
+     * @param array<int, string> $newResources
      */
     public function addResources(array $newResources): void
     {

src/bundle/ApiPlatform/OpenApiFactory.php

@@ -73,7 +73,6 @@ private function insertExampleFilesContent(OpenApi $openApi): void
                 }
 
                 $responses = $operation->getResponses();
-
                 if ($responses === null) {
                     continue;
                 }

src/bundle/ApiPlatform/SchemasCollectionFactory.php

@@ -17,15 +17,12 @@
  */
 final class SchemasCollectionFactory implements SchemasCollectionFactoryInterface
 {
-    /**
-     * @var array<SchemasProviderInterface>
-     */
+    /** @var array<SchemasProviderInterface> */
     private array $providers = [];
 
     public function create(): SchemasCollection
     {
         $schemas = [];
-
         foreach ($this->providers as $provider) {
             $schemas = array_merge($schemas, $provider->getSchemas());
         }

src/bundle/DependencyInjection/Compiler/ClassNameResourceNamePass.php

@@ -4,16 +4,17 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
 
 namespace Ibexa\Bundle\Rest\DependencyInjection\Compiler;
 
 use Ibexa\Bundle\Rest\ApiPlatform\ClassNameResourceNameCollectionFactory;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
-class ClassNameResourceNamePass implements CompilerPassInterface
+final readonly class ClassNameResourceNamePass implements CompilerPassInterface
 {
-    public const API_PLATFORM_RESOURCE_SERVICE_TAG = 'ibexa.api_platform.resource';
+    public const string API_PLATFORM_RESOURCE_SERVICE_TAG = 'ibexa.api_platform.resource';
 
     public function process(ContainerBuilder $container): void
     {
@@ -28,7 +29,7 @@ public function process(ContainerBuilder $container): void
             $taggedServiceDefinition = $container->getDefinition($id);
             $definition->addMethodCall(
                 'addResources',
-                [[$taggedServiceDefinition->getClass()]]
+                [[$taggedServiceDefinition->getClass()]],
             );
         }
     }

src/bundle/DependencyInjection/Compiler/SchemaProviderPass.php

@@ -4,6 +4,7 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
 
 namespace Ibexa\Bundle\Rest\DependencyInjection\Compiler;
 
@@ -12,9 +13,9 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
-class SchemaProviderPass implements CompilerPassInterface
+final readonly class SchemaProviderPass implements CompilerPassInterface
 {
-    public const API_PLATFORM_SCHEMA_PROVIDER_SERVICE_TAG = 'ibexa.api_platform.schemas_provider';
+    public const string API_PLATFORM_SCHEMA_PROVIDER_SERVICE_TAG = 'ibexa.api_platform.schemas_provider';
 
     public function process(ContainerBuilder $container): void
     {
@@ -28,7 +29,7 @@ public function process(ContainerBuilder $container): void
         foreach ($taggedServiceIds as $serviceId => $attributes) {
             $definition->addMethodCall(
                 'addProvider',
-                [new Reference($serviceId)]
+                [new Reference($serviceId)],
             );
         }
     }

src/bundle/Resources/config/api_platform.yml

@@ -16,7 +16,7 @@ services:
             index_1: '@ibexa.api_platform.ibexa_openapi.factory'
 
     ibexa.api_platform.ibexa_openapi.factory:
-        class: 'Ibexa\Bundle\Rest\ApiPlatform\OpenApiFactory'
+        class: Ibexa\Bundle\Rest\ApiPlatform\OpenApiFactory
         decorates: ibexa.api_platform.openapi.factory
         arguments:
             - '@.inner'
@@ -30,7 +30,6 @@ services:
 
     Ibexa\Bundle\Rest\ApiPlatform\ClassNameResourceNameCollectionFactory: ~
 
-
     # Collecting schemas
 
     Ibexa\Bundle\Rest\ApiPlatform\SchemasCollectionFactory: ~

src/lib/ApiPlatform/SchemasCollection.php

@@ -8,13 +8,14 @@
 
 namespace Ibexa\Rest\ApiPlatform;
 
-final class SchemasCollection implements \IteratorAggregate, \Countable
+final readonly class SchemasCollection implements \IteratorAggregate, \Countable
 {
     /**
      * @param array<string, mixed> $schemas
      */
-    public function __construct(private readonly array $schemas = [])
-    {
+    public function __construct(
+        private array $schemas = [],
+    ) {
     }
 
     /**

src/lib/ApiPlatform/SchemasProvider.php

@@ -11,14 +11,14 @@
 use Symfony\Component\HttpKernel\KernelInterface;
 use Symfony\Component\Yaml\Yaml;
 
-final class SchemasProvider implements SchemasProviderInterface
+final readonly class SchemasProvider implements SchemasProviderInterface
 {
     /**
      * @param array<string> $files
      */
     public function __construct(
-        private readonly KernelInterface $kernel,
-        private readonly array $files,
+        private KernelInterface $kernel,
+        private array $files,
     ) {
     }