Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8470: Upgraded codebase to Symfony 6 #138

Merged
merged 14 commits into from
Feb 4, 2025
+208 −475
Merged

IBX-8470: Upgraded codebase to Symfony 6 #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b83ff9d
[Composer] Dropped obsolete ci-scripts from dev requirements
alongosz Nov 19, 2024
a1f95d0
Bumped Symfony packages requirements to ^6.4
alongosz Nov 19, 2024
ba943a7
Dropped Symfony Container dependency from REST base controller
alongosz Nov 19, 2024
f896efc
Dropped Symfony Container dependency from Content controller
alongosz Nov 19, 2024
c7bb90d
[Security] Aligned RestAuthenticator with Symfony 6
alongosz Nov 20, 2024
f88a67a
Improved Controllers code quality
alongosz Nov 20, 2024
cce03fd
Aligned SessionController with Symfony 6
alongosz Nov 20, 2024
bc602cc
[PHPStan] Removed resolved issues from the baseline
alongosz Nov 20, 2024
162e2fe
[Tests] Aligned VisitorTest with Symfony 6
alongosz Nov 20, 2024
a776cde
Fixed deprecated controller syntax in routes definitions usage
adamwojs Dec 28, 2024
1d6482f
fixup! Bumped Symfony packages requirements to ^6.4
adamwojs Feb 4, 2025
f4f9539
Updated phpstan baseline
adamwojs Feb 4, 2025
ddce577
Fixed Ibexa\Tests\Rest\Server\Output\ValueObjectVisitor\RestExecutedV…
adamwojs Feb 4, 2025
2be66ff
Fixed Ibexa\Tests\Integration\Rest\UriParser\UriParserTest::testMatch…
adamwojs Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,23 @@
"ibexa/core": "~5.0.x-dev",
"ibexa/polyfill-php82": "^1.0",
"lexik/jwt-authentication-bundle": "^2.8",
"symfony/config": "^5.3",
"symfony/dependency-injection": "^5.3",
"symfony/event-dispatcher": "^5.3",
"symfony/expression-language": "^5.3",
"symfony/form": "^5.3",
"symfony/http-foundation": "^5.3",
"symfony/http-kernel": "^5.3",
"symfony/routing": "^5.3",
"symfony/security-bundle": "^5.3",
"symfony/security-csrf": "^5.3",
"symfony/yaml": "^5.3",
"symfony/config": "^6.4",
"symfony/dependency-injection": "^6.4",
"symfony/event-dispatcher": "^6.4",
"symfony/expression-language": "^6.4",
"symfony/form": "^6.4",
"symfony/http-foundation": "^6.4",
"symfony/http-kernel": "^6.4",
"symfony/routing": "^6.4",
"symfony/security-bundle": "^6.4",
"symfony/security-csrf": "^6.4",
"symfony/yaml": "^6.4",
"webmozart/assert": "^1.11"
},
"require-dev": {
"ibexa/ci-scripts": "^0.2@dev",
"ibexa/code-style": "~2.0.0",
"ibexa/doctrine-schema": "~5.0.x-dev",
"ibexa/test-core": "^0.1.x-dev",
"ibexa/test-core": "~5.0.x-dev",
"justinrainbow/json-schema": "^5.2",
"matthiasnoback/symfony-dependency-injection-test": "^4.1",
"nyholm/psr7": "^1.1",
Expand All @@ -58,8 +57,8 @@
"phpstan/phpstan-symfony": "^1.3",
"phpstan/phpstan-webmozart-assert": "^1.2",
"phpunit/phpunit": "^9.6",
"symfony/browser-kit": "^5.3",
"symfony/http-client": "^5.3"
"symfony/browser-kit": "^6.4",
"symfony/http-client": "^6.4"
},
"config": {
"allow-plugins": {
Expand Down
85 changes: 0 additions & 85 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,46 +25,16 @@ parameters:
count: 1
path: src/bundle/CorsOptions/RestProvider.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Compiler\\\\FieldTypeProcessorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/FieldTypeProcessorPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Compiler\\\\InputHandlerPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/InputHandlerPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Compiler\\\\InputParserPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/InputParserPass.php

-
message: "#^Argument of an invalid type array\\|bool\\|float\\|int\\|string\\|null supplied for foreach, only iterables are supported\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/OutputVisitorPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Compiler\\\\OutputVisitorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/OutputVisitorPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Compiler\\\\ValueObjectVisitorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Compiler/ValueObjectVisitorPass.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\Configuration\\:\\:addRestRootResourcesSection\\(\\) has parameter \\$rootNode with no type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/Configuration.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\IbexaRestExtension\\:\\:prepend\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaRestExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Rest\\\\DependencyInjection\\\\IbexaRestExtension\\:\\:prependRouterConfiguration\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -420,16 +390,6 @@ parameters:
count: 1
path: src/contracts/Output/Visitor.php

-
message: "#^Offset 0 does not exist on array\\<int, string\\|null\\>\\|string\\|null\\.$#"
count: 1
path: src/contracts/Output/Visitor.php

-
message: "#^Parameter \\#1 \\$key of method Symfony\\\\Component\\\\HttpFoundation\\\\ResponseHeaderBag\\:\\:remove\\(\\) expects string, int\\|string given\\.$#"
count: 1
path: src/contracts/Output/Visitor.php

-
message: "#^Property Ibexa\\\\Contracts\\\\Rest\\\\Output\\\\Visitor\\:\\:\\$statusCode \\(int\\) does not accept null\\.$#"
count: 1
Expand Down Expand Up @@ -950,21 +910,6 @@ parameters:
count: 1
path: src/lib/Output/ValueObjectVisitor/ContentObjectStates.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Controller\\:\\:setInputDispatcher\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Server/Controller.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Controller\\:\\:setRepository\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Server/Controller.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Controller\\:\\:setRouter\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Server/Controller.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Controller\\\\BinaryContent\\:\\:getImageVariation\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Variation\\\\Values\\\\Variation but returns Ibexa\\\\Rest\\\\Server\\\\Values\\\\CachedValue\\.$#"
count: 1
Expand Down Expand Up @@ -995,21 +940,6 @@ parameters:
count: 1
path: src/lib/Server/Controller/Bookmark.php

-
message: "#^Cannot call method get\\(\\) on Symfony\\\\Component\\\\DependencyInjection\\\\ContainerInterface\\|null\\.$#"
count: 2
path: src/lib/Server/Controller/Content.php

-
message: "#^Cannot call method getCurrentRequest\\(\\) on object\\|null\\.$#"
count: 1
path: src/lib/Server/Controller/Content.php

-
message: "#^Cannot call method handle\\(\\) on object\\|null\\.$#"
count: 1
path: src/lib/Server/Controller/Content.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Controller\\\\Content\\:\\:loadContent\\(\\) should return Ibexa\\\\Rest\\\\Server\\\\Values\\\\RestContent but returns Ibexa\\\\Rest\\\\Server\\\\Values\\\\CachedValue\\.$#"
count: 1
Expand All @@ -1030,11 +960,6 @@ parameters:
count: 1
path: src/lib/Server/Controller/Content.php

-
message: "#^Parameter \\#1 \\$locationId of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\LocationService\\:\\:loadLocation\\(\\) expects int, int\\|null given\\.$#"
count: 1
path: src/lib/Server/Controller/Content.php

-
message: "#^Parameter \\#1 \\$parentLocationId of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\LocationService\\:\\:newLocationCreateStruct\\(\\) expects int, string given\\.$#"
count: 1
Expand Down Expand Up @@ -2355,11 +2280,6 @@ parameters:
count: 1
path: src/lib/Server/Input/Parser/UserGroupUpdate.php

-
message: "#^Parameter \\#1 \\$fieldDefIdentifier of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\ContentStruct\\:\\:setField\\(\\) expects string, int\\|string given\\.$#"
count: 1
path: src/lib/Server/Input/Parser/UserGroupUpdate.php

-
message: "#^Parameter \\#1 \\$locationId of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\LocationService\\:\\:loadLocation\\(\\) expects int, string given\\.$#"
count: 1
Expand All @@ -2370,11 +2290,6 @@ parameters:
count: 1
path: src/lib/Server/Input/Parser/UserUpdate.php

-
message: "#^Parameter \\#1 \\$fieldDefIdentifier of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\ContentStruct\\:\\:setField\\(\\) expects string, int\\|string given\\.$#"
count: 1
path: src/lib/Server/Input/Parser/UserUpdate.php

-
message: "#^Method Ibexa\\\\Rest\\\\Server\\\\Input\\\\Parser\\\\VersionUpdate\\:\\:parse\\(\\) has parameter \\$data with no value type specified in iterable type array\\.$#"
count: 1
Expand Down
Loading
Loading