IBX-9587: Fixed failing REST requests after Symfony 6 upgrade #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This is a follow-up to Symfony 6 upgrade (#138). Fixing issues that surfaced via the functional tests after merging full-stack app.
Issue 1: OPTIONS requests single-colon controller reference
OPTIONS
requests controller mapper used obsolete single-colon controller reference that stopped working in Symfony 6.Issue 2: Obsolete single-colon refresh session controller reference
SessionController::refreshSessionAction
controller used obsolete single-colon reference as well.Test & code quality issues
LocationTest
created suffix using mismatched case in one placetestCreatelocation
instead oftestCreateLocation
which made tests fail on PostgreSQL instance (not visible in tests, noticed by accident). In short: it createdtestCreateLocation*
remote ID but queried fortestCreatelocation*
remote ID, which doesn't work on case-sensitive PostgreSQL.BookmarkTest
testDeleteBookmarkReturnNotFound
andtestIsBookmarkedReturnsNotFound
not rely on hard-coded pre-defined database ID, as it's quite volatile. Some other tests at some point make this Location bookmarked and thus running the same test without resetting the database is impossible. Instead I made these tests dependent ontestDeleteBookmark
to check it against just deleted bookmark.BookmarkTest
code quality.For QA:
Requires REST client.
Ad Issue 1. OPTIONS request
/api/ibexa/v2/
Ad Issue 2. Session Refresh
POST
/api/ibexa/v2/user/sessions
with a proper payload and copy created session IDPOST
/api/ibexa/v2/user/sessions/<your_session_identifier>/refresh