Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9584: Resolved Symfony 6.x deprecations #146

Merged
merged 7 commits into from
Feb 23, 2025
Merged

IBX-9584: Resolved Symfony 6.x deprecations #146

merged 7 commits into from
Feb 23, 2025

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 19, 2025 •
edited
Loading

🎫 Issue IBX-9584

Description:

Enabled and executed automatic refactoring rules defined for Symfony 6.x.

  • [HTTP] Replaced deprecated usage of Symfony\Component\HttpFoundation\RequestMatcher
  • [Security] Replaced deprecated usage of Symfony\Component\Security\Core\Security
  • [Serializer] Fixed usages of deprecated Symfony\Component\Serializer\Normalizer{ContextAwareDenormalizerInterface, ContextAwareNormalizerInterface};

Additionally added rector job to CI setup to prevent merging up code which is not compatible with Symfony 6+.

For QA:

Sanities.

Documentation:

N/A

konradoboza
konradoboza reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing here.

@adamwojs adamwojs force-pushed the sf6_deprecations branch 2 times, most recently from 2b476da to 0645d2d Compare February 23, 2025 08:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwojs adamwojs marked this pull request as ready for review February 23, 2025 09:53
@adamwojs adamwojs merged commit 4c6db56 into main Feb 23, 2025
11 checks passed
@adamwojs adamwojs deleted the sf6_deprecations branch February 23, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza left review comments

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @konradoboza @Steveb-p @alongosz @tischsoic