From e0fb95a7efa13c7d92ef2df306607de5eb671b38 Mon Sep 17 00:00:00 2001 From: Jakub Brzegowski Date: Fri, 1 Sep 2023 17:18:01 +0200 Subject: [PATCH] IBX-6314: Apply microcopy guidelines and adjust translation keys and domains (#59) --- features/browser/formats.feature | 2 +- .../Resources/translations/user_settings.en.xliff | 12 ++++++------ src/lib/UserSetting/Group/EditContentGroup.php | 2 +- src/lib/UserSetting/Setting/Language.php | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/features/browser/formats.feature b/features/browser/formats.feature index 6ee4a90..921004f 100644 --- a/features/browser/formats.feature +++ b/features/browser/formats.feature @@ -3,7 +3,7 @@ @APIUser:admin Scenario: User is asked for setting a new password when his password is in an unsupported format - Given I create a user "UnsupportedPasswordUser" with last name "User" in group "Anonymous Users" + Given I create a user "UnsupportedPasswordUser" with last name "User" in group "Anonymous users" And a user "UnsupportedPasswordUser" has password in unsupported format When I am viewing the pages on siteaccess "site" as "UnsupportedPasswordUser" Then the url should match "/site/user/forgot-password/migration" diff --git a/src/bundle/Resources/translations/user_settings.en.xliff b/src/bundle/Resources/translations/user_settings.en.xliff index af4bcd4..74f2ac3 100644 --- a/src/bundle/Resources/translations/user_settings.en.xliff +++ b/src/bundle/Resources/translations/user_settings.en.xliff @@ -82,8 +82,8 @@ key: settings.group.edit_content.description - Edit Content - Edit Content + Edit + Edit key: settings.group.edit_content.name @@ -107,8 +107,8 @@ key: settings.group.location.name - Back Office language - Back Office language + Language + Language key: settings.language.value.description @@ -147,8 +147,8 @@ key: settings.timezone.value.title - User setting '%identifier%' updated. - User setting '%identifier%' updated. + User settings '%identifier%' updated. + User settings '%identifier%' updated. key: user_setting.update.success diff --git a/src/lib/UserSetting/Group/EditContentGroup.php b/src/lib/UserSetting/Group/EditContentGroup.php index 11d9d96..77ea3b7 100644 --- a/src/lib/UserSetting/Group/EditContentGroup.php +++ b/src/lib/UserSetting/Group/EditContentGroup.php @@ -25,7 +25,7 @@ public function __construct( public function getName(): string { return $this->translator->trans( - /** @Desc("Edit Content") */ + /** @Desc("Edit") */ 'settings.group.edit_content.name', [], 'user_settings' diff --git a/src/lib/UserSetting/Setting/Language.php b/src/lib/UserSetting/Setting/Language.php index f8bde97..deba324 100644 --- a/src/lib/UserSetting/Setting/Language.php +++ b/src/lib/UserSetting/Setting/Language.php @@ -111,7 +111,7 @@ private function getTranslatedName(): string private function getTranslatedDescription(): string { return $this->translator->trans( - /** @Desc("Back Office language") */ + /** @Desc("Language") */ 'settings.language.value.description', [], 'user_settings'