From 26ea61620805690903b3ff35536e0a7abe1a67b0 Mon Sep 17 00:00:00 2001 From: Gil Forsyth Date: Thu, 13 Jun 2024 16:50:15 -0400 Subject: [PATCH] chore(signature): swap order of arguments to `compatible` Should be `implementation, interface_def`, not the other way around --- ibis/backends/tests/test_signatures.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ibis/backends/tests/test_signatures.py b/ibis/backends/tests/test_signatures.py index 3a1417daf727a..4761d2028ecfc 100644 --- a/ibis/backends/tests/test_signatures.py +++ b/ibis/backends/tests/test_signatures.py @@ -23,4 +23,5 @@ def test_signatures(base_cls, method, backend_cls): base_sig = inspect.signature(getattr(base_cls, method)) backend_sig = inspect.signature(getattr(backend_cls, method)) - assert compatible(base_sig, backend_sig, check_annotations=False) + # Usage is compatible(implementation_signature, defined_interface_signature, ...) + assert compatible(backend_sig, base_sig, check_annotations=False)