Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Difficulty finding method reference #10161

Closed
1 task done
Riezebos opened this issue Sep 18, 2024 · 7 comments
Closed
1 task done

docs: Difficulty finding method reference #10161

Riezebos opened this issue Sep 18, 2024 · 7 comments
Assignees
Labels
docs Documentation related issues or PRs
Milestone

Comments

@Riezebos
Copy link
Contributor

Please describe the issue

As a user getting used to Ibis coming from a Pandas, I often want to find out exactly how a function works.

In many cases, the info is shown when hovering over a method in VSCode, but this doesn't always work as e.g. deferred expressions don't always show all methods that a Column can have.

Today, I was using value_counts and wanted to know whether I could control the name of the column with the count.

Searching the docs gave me:
image

The place in the docs that I needed turned out to be: https://ibis-project.org/reference/expression-generic.html#ibis.expr.types.generic.Column.value_counts

But in the search menu that page is quite low, and the link in the search doesn't go to the place where that function is defined, as it is used elsewhere in the page as an example.

Would it be possible rank matches from Reference higher in the search results? Or maybe have a separate search box somewhere that can be used to purely search within the Reference?

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Riezebos Riezebos added the docs Documentation related issues or PRs label Sep 18, 2024
@gforsyth
Copy link
Member

gforsyth commented Sep 18, 2024

Hey @Riezebos -- the reference documentation should definitely rank higher than stuff in release notes. I'm not sure what's happening here because I see the reference page as the first hit, but I'll try to figure out why that's not happening reliably.

2024-09-18_11-00

@gforsyth
Copy link
Member

@Riezebos -- can you try searching again on your end?

There's a possibility that you got very unlucky and happened to search while our CI was in the middle of updating the search configuration to update the document rankings -- I'd like to rule that out if we can.

@Riezebos
Copy link
Contributor Author

Ah, now it's also at the top for me!

Another example that might be different is to_parquet:
image

I can run t.to_parquet() on a table expression, which seems to not be documented on the table expressions page. I guess it might be automatically added when the backend is DuckDB?

It is documented on the Duckdb backend page: https://ibis-project.org/backends/duckdb#ibis.backends.duckdb.Backend.to_parquet

But when I search for to_parquet or for duckdb to_parquet the duckdb backend page is not in the search results at all.

@gforsyth
Copy link
Member

Heh, just fixed those missing to_* methods in #10164, but keep the search issues coming!!

@Riezebos
Copy link
Contributor Author

Wow this is getting challenging!

How about this one:
Searching for mutate has the Table expressions page as third on the list, and none of the results from that page are the actual direct link to the docs of the mutate method. (They are mostly examples, and the bottom one is to the overview of methods of Table)

image

@cpcloud cpcloud added this to the 10.0 milestone Sep 18, 2024
@gforsyth
Copy link
Member

Should be good now @Riezebos !
Something happened on one of our CI runs and none of the API docs were added to the search index. I've regenerated it and now mutate is the top result. Going to try to track down what broke down, though

@Riezebos
Copy link
Contributor Author

Amazing, that was quick!

@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
Archived in project
Development

No branches or pull requests

3 participants