Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency sqlglot to v26 #10570

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 11, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sqlglot >=23.4,<25.35 -> >=23.4,<26.1 age adoption passing confidence

Release Notes

tobymao/sqlglot (sqlglot)

v26.0.0

Compare Source

💥 BREAKING CHANGES
✨ New Features
🐛 Bug Fixes

v25.34.1

Compare Source

💥 BREAKING CHANGES
✨ New Features
🔧 Chores

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Issues or PRs related to dependencies label Dec 11, 2024
@renovate renovate bot force-pushed the renovate/sqlglot-26.x branch from 004eece to 5981e08 Compare December 11, 2024 07:43
@IndexSeek
Copy link
Member

It seems that the mssql temporal tests are running into trouble after tobymao/sqlglot@ab10851.

The timestamp_col is now an UnknownColumn.

Would the fix for this be to add this mapping

    typecode.DATETIME2: dt.Timestamp,
    typecode.SMALLDATETIME: dt.Timestamp,

to

_from_sqlglot_types = {

Here are some quick references to those types for MSSQL:

https://learn.microsoft.com/en-us/sql/t-sql/data-types/smalldatetime-transact-sql?view=sql-server-ver16
https://learn.microsoft.com/en-us/sql/t-sql/data-types/datetime2-transact-sql?view=sql-server-ver16

@github-actions github-actions bot added the sql Backends that generate SQL label Dec 13, 2024
@IndexSeek
Copy link
Member

I gave my idea a try. My intention is that this would be compatible with lower versions of SQLGlot.

Happy to adjust this as needed!

Copy link
Contributor Author

renovate bot commented Dec 13, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@IndexSeek IndexSeek force-pushed the renovate/sqlglot-26.x branch from e331011 to 3c3047f Compare December 15, 2024 18:55
@cpcloud cpcloud added this to the 10.0 milestone Dec 16, 2024
@cpcloud
Copy link
Member

cpcloud commented Dec 16, 2024

@IndexSeek Excellent work, thank you!

@github-actions github-actions bot added the tests Issues or PRs related to tests label Dec 16, 2024
@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Dec 16, 2024
@cpcloud cpcloud force-pushed the renovate/sqlglot-26.x branch from 5a6e447 to 544b006 Compare December 16, 2024 11:51
@cpcloud cpcloud removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Dec 16, 2024
@cpcloud cpcloud enabled auto-merge (rebase) December 16, 2024 12:14
@cpcloud cpcloud merged commit c7b5fb9 into main Dec 16, 2024
77 checks passed
@cpcloud cpcloud deleted the renovate/sqlglot-26.x branch December 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants