Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery): fix array concat test #10584

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 16, 2024

Fixes the upstream failing test cases for bigquery.

@cpcloud cpcloud added this to the 10.0 milestone Dec 16, 2024
@cpcloud cpcloud added the bigquery The BigQuery backend label Dec 16, 2024
@cpcloud cpcloud requested a review from gforsyth December 16, 2024 18:16
@cpcloud
Copy link
Member Author

cpcloud commented Dec 16, 2024

Tests are now correctly xfailing:

ibis/backends/tests/test_array.py::test_array_concat_with_null[bigquery-right] XFAIL (bigquery treats null arrays as empty and a ValueError is raised from `pd.isna` when the value is not a
truthy value)                                                            [ 50%]
ibis/backends/tests/test_array.py::test_array_concat_with_null[bigquery-left] XFAIL (bigquery treats null arrays as empty and a ValueError is raised from `pd.isna` when the value is not a
truthy value)                                                            [100%]

================================================================================= 36 deselected, 2 xfailed in 50.23s =================================================================================

@github-actions github-actions bot added the tests Issues or PRs related to tests label Dec 16, 2024
@cpcloud cpcloud merged commit e54b306 into ibis-project:main Dec 16, 2024
81 checks passed
@cpcloud cpcloud deleted the fix-bigquery-test branch December 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant