fix(api): ensure memtable schema and columns match #10617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Before this change, if you pass a
SchemaLike
that isn't actually aSchema
, it won't automatically rename the auto-generated pandas column names. For example:This PR goes ahead and constructs the
Schema
, if passed—work that was going to be done anyway. That way,getattr(schema, "names")
finds the passed names, and the rename is performed.