Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flink): override default install instructions #7738

Closed
1 task done
deepyaman opened this issue Dec 13, 2023 · 4 comments
Closed
1 task done

docs(flink): override default install instructions #7738

deepyaman opened this issue Dec 13, 2023 · 4 comments
Assignees
Labels
docs Documentation related issues or PRs flink Issues or PRs related to Flink
Milestone

Comments

@deepyaman
Copy link
Contributor

Please describe the issue

Installing the Flink backend should be done with pip install ibis-framework apache-flink (or pip install ibis-framework 'apache-flink>=1.18'?). This differs from the installation instructions for every other backend, so probably needs to be overridden in the overlay.

Also, we don't yet have a path to supporting installation with conda/mamba, pending Flink being made available via conda-forge.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@deepyaman deepyaman added the docs Documentation related issues or PRs label Dec 13, 2023
@deepyaman
Copy link
Contributor Author

/take

@gforsyth
Copy link
Member

For the pip install question, was this the issue of the beamer pin leaving us with an older version of pyarrow?

Because that only impacts ibis developers and users of the flink backend and we've dealt with pyarrow pins before (mostly with snowflake)

@deepyaman
Copy link
Contributor Author

For the pip install question, was this the issue of the beamer pin leaving us with an older version of pyarrow?

Because that only impacts ibis developers and users of the flink backend and we've dealt with pyarrow pins before (mostly with snowflake)

@gforsyth Yes; in order to avoid that, we've not added apache-flink to the "flink" extra requirements.

I think @cpcloud also mentioned the Snowflake example (recently resolved), and that we could find a way to include the extra while not downgrading PyArrow for every other backend during development/testing.

I'm flexible on this; if you all think it's easy/convenient to override the PyArrow pin for dev/CI, it would obviously be nice to be able to just do pip install ibis-framework[flink]. That being said, pip install ibis-framework apache-flink isn't all that ugly, either.

@cpcloud
Copy link
Member

cpcloud commented Dec 16, 2023

Closed by #7751.

@cpcloud cpcloud closed this as completed Dec 16, 2023
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Dec 16, 2023
@cpcloud cpcloud added this to the 8.0 milestone Dec 16, 2023
@cpcloud cpcloud added the flink Issues or PRs related to Flink label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs flink Issues or PRs related to Flink
Projects
Archived in project
Development

No branches or pull requests

3 participants