refactor: use sge.DPipe for StringConcat #8340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation in the SQLGlot compiler shoud use DPipe. Exasol still needs it's own visit_StringConcat() because it doesn't handle NULLs properly
|
This won't work, because of the NULL handling of these other backends. When I wrote those implementations there were all necessary to get things passing. I tried DPipe first, but that doesn't exist/work on all backends, as is seen in the test suite :) |
|
uuuughhhhhhh |
|
Well, I think you could've left the DPipe in the base class, and left the others, but closing it is also fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation in the SQLGlot compiler should use DPipe.
Exasol still needs it's own visit_StringConcat()
because it doesn't handle NULLs properly
This is in preparation for #8270, which will rely upon this.