Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ibis mssql backend, add parameter for table_option #9436

Open
1 task done
ruiyang2015 opened this issue Jun 24, 2024 · 2 comments
Open
1 task done

feat: ibis mssql backend, add parameter for table_option #9436

ruiyang2015 opened this issue Jun 24, 2024 · 2 comments
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend

Comments

@ruiyang2015
Copy link

Is your feature request related to a problem?

for mssql backend, the current signature does not allow additional table options for ibis.mssql.create_table,
for sql server/synapse, we will need additional table options when creating a table. like cluster data compression etc.
the syntax is like this: create table foo (columns_def..) with ( <table options>)

What is the motivation behind your request?

so we can create a table with additional table level options, and those can not be done with an alter table command.

Describe the solution you'd like

for ibis.mssql.create_table(...., table_options: str) to allow additional table options during create table.

What version of ibis are you running?

9.1.0

What backend(s) are you using, if any?

Synapse

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ruiyang2015 ruiyang2015 added the feature Features or general enhancements label Jun 24, 2024
@gforsyth gforsyth added the mssql The Microsoft SQL Server backend label Jun 26, 2024
@gforsyth
Copy link
Member

Hey @ruiyang2015 -- we currently support similar extensions for a few of our backends that have more complex table creation options.

In the meantime, you can certainly work around this by using raw_sql or a standalone dbapi connection to first create the table before interacting with it via Ibis.

@ruiyang2015
Copy link
Author

Hey @ruiyang2015 -- we currently support similar extensions for a few of our backends that have more complex table creation options.

In the meantime, you can certainly work around this by using raw_sql or a standalone dbapi connection to first create the table before interacting with it via Ibis.

yes, but that require a lot of extra work that ibis is trying to help us avoid, like we want to create a table from pandas.df or pyarrow table, we do not need to deal with hand crafted column schemas.
alternatively, wondering if you can have create_table function that do not execute the code, but return the create sql, so we can append additional table options to it, that will be helpful too in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend
Projects
Status: backlog
Development

No branches or pull requests

2 participants