refactor(sql): make compilers usable with a base install #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
transform-in-compilers-instead-of-backend
branch
2 times, most recently
from
1ccdf78 to
9e9ec9a
Compare
cpcloud
force-pushed
the
transform-in-compilers-instead-of-backend
branch
from
0ae0117 to
ef21fbc
Compare
cpcloud
force-pushed
the
transform-in-compilers-instead-of-backend
branch
from
50c43d5 to
4cf502a
Compare
cpcloud
force-pushed
the
transform-in-compilers-instead-of-backend
branch
from
e14cd29 to
cd73de1
Compare
|
cc @jonmmease This PR makes It'll be available in 9.3, which we should be releasing this week! |
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
commented
Aug 5, 2024
jcrist
approved these changes
Aug 5, 2024
| ✅ sum(x) over (order by y desc nulls last) | ||
| 🚫 sum(x) over (order by y asc nulls last) | ||
| ✅ sum(x) over (order by y asc nulls first) | ||
| 🚫 sum(x) over (order by y desc nulls first) |
There was a problem hiding this comment.
Unicode in comments is not something I would have thought of, but is kinda nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our compilers usable without having any backend dependencies installed.
The main goal is to make
ibis.to_sqlavoid hitting any backend dependencies.The approach here is to move all sqlglot-ifcation, including
entirely into the compilers.
One benefit of this is that now the output of
ibis.to_sqland the output ofcon.compilewill actually match. Previously, they would only match when the expression was attached to a backend.