Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization is probably wonky #19

Open
ibrahima opened this issue Jun 30, 2009 · 2 comments
Open

Synchronization is probably wonky #19

ibrahima opened this issue Jun 30, 2009 · 2 comments

Comments

@ibrahima
Copy link
Owner

No basis for this, but I have a hunch that we've got some screwy/incorrect synchronization going on which might cause a few problems.

@ibrahima
Copy link
Owner Author

Yeah, I'm pretty sure that synchronized run() has no effect at all. So, we basically suck.

Synchronizing a method just makes it so that multiple threads can't invoke that method at once, it doesn't magically protect all the variables inside. Since each thread has its own run() method, synchronized does nothing.

@ibrahima
Copy link
Owner Author

Working on it. I think it should be mostly good now. I want to remove all instances of sleep and use wait/notify though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant