Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emitter_kwargs to optimizer ask and tell #159

Merged
merged 14 commits into from
Jul 7, 2021
Merged

Add emitter_kwargs to optimizer ask and tell #159

merged 14 commits into from
Jul 7, 2021

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Jul 7, 2021 •
edited
Loading

Description

Resolves #136. See there for more info. Merge #157 before this PR.

Changelog Description

Allow passing in kwargs to emitter ask() and tell() via emitter_kwargs in optimizer (#159)

TODO

  • Add emitter_kwargs
  • Update docstrings
  • Add tests

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • This PR is ready to go

@btjanaka btjanaka added this to the v0.4.0 milestone Jul 7, 2021
@btjanaka btjanaka merged commit 05f4133 into master Jul 7, 2021
@btjanaka btjanaka deleted the emitter-kwargs branch July 7, 2021 21:45
This was referenced Jul 16, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] add emitter_kwargs to optimizer ask and tell
1 participant
@btjanaka