Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor visualize tests #370

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Refactor visualize tests #370

merged 3 commits into from
Sep 13, 2023

Conversation

btjanaka
Copy link
Member

Description

This PR splits the tests for ribs.visualize into multiple files. Test methods and baseline images are also renamed since their filepaths now include the name of their respective visualization function.

TODO

  • Split up tests
  • Check that number of tests matches (93)

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 8efa0f2 into master Sep 13, 2023
@btjanaka btjanaka deleted the visualize-test branch September 13, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant