Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link from interpretation of a charter should reference idno of main entry #1146

Open
NTsch opened this issue Apr 18, 2023 · 3 comments
Open
Assignees
Milestone

Comments

@NTsch
Copy link
Collaborator

NTsch commented Apr 18, 2023

In charters which are an interpretation of another charter, the text of the link to the main entry (e.g. "This charter is an interpretation of : 1306-99-99_Paris") is created from the atom:id of the target, not its cei:idno. This leads to a wrong link name in cases where a cei:idno is modified. It would be preferable to use the target's cei:idno, so that the name is consistent everywhere.

@NTsch NTsch self-assigned this Apr 18, 2023
@NTsch NTsch added this to the versions milestone Apr 18, 2023
@StephanMa
Copy link
Collaborator

To be clear... this issue is just about displaying the "Reference" not referencing data-wise?

@NTsch
Copy link
Collaborator Author

NTsch commented Apr 18, 2023

To be clear... this issue is just about displaying the "Reference" not referencing data-wise?

The link itself works, only the "This charter is an interpretation of : 1306-99-99_Paris" text is wrong, since that name is taken from the atom:ID.

@yngwi
Copy link
Collaborator

yngwi commented Apr 18, 2023

The system is a bit convoluted with regards to this. The atom id is created from the archive/fond (or collection) and the signature (idno) when the charter is imported initially. While archive and fond are something only relevant in Monasterium and conceptually persistent, the idno is a metadata related to the actual charter (its signature in the archive) and can in theory be changed at any time (for instance because it was wrong initially due to a typo). It shouldn't be used for database purposes (linking), that's what atom-id is for that also shouldn't change at all (imo). It's unfortunate that we decided to have a "speaking" database identifier but it is now as it is. This just for clarification :)

Using the idno for display purposes is fine in my opinion as we actually want to show the human-relevant metadata (archival signature) here not something that is mostly relevant to the database like the atom-id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants