Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metric computation to work with lat/lon region bounds #283

Open
bnubald opened this issue Jul 9, 2024 · 2 comments
Open

Update metric computation to work with lat/lon region bounds #283

bnubald opened this issue Jul 9, 2024 · 2 comments
Assignees
@bnubald
Labels
bug Something isn't working enhancement New feature or request
Milestone
v0.3.0

Comments

@bnubald
Copy link
Collaborator

bnubald commented Jul 9, 2024

  • IceNet version: v0.2.9_dev
  • Python version: 3.11

Description

Please see details in #282 pull request.

In short, as of this post, forecast output generation (png, mp4) works with lat/lon region definition, but metrics generation such as sie, binary accuracy, etc within icenet/plotting/forecast.py needs changes to Mask class to allow bounding the mask output (e.g. active cell mask). Currently this is not done, hence the metric outputs will be incorrect if defining a region based on lat/lon.
@bnubald bnubald added the enhancement New feature or request label Jul 9, 2024
@bnubald bnubald added this to the v0.3.0 milestone Jul 9, 2024
@bnubald
Copy link
Collaborator Author

bnubald commented Jul 9, 2024

In meantime, these metric plots should not be output to avoid confusing user!

@bnubald bnubald mentioned this issue Jul 9, 2024
Open
@bnubald bnubald self-assigned this Jul 9, 2024
@bnubald bnubald added the bug Something isn't working label Jul 9, 2024
bnubald added a commit to bnubald/icenet that referenced this issue Jul 10, 2024
@bnubald
Dev icenet-ai#283: raise NotImplementedError if lat/lon bounds for me…
e89aaa7 
…trics

Also started work towards enabling lat/lon bounds for metrics
@bnubald
Copy link
Collaborator Author

bnubald commented Jul 10, 2024

In meantime, these metric plots should not be output to avoid confusing user!

Resolved by latest commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnubald bnubald

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@bnubald