Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice explorer does not reproduce the graphs of Standard Graphs #266

Closed
cmspinto opened this issue Jun 19, 2024 · 9 comments
Closed

Advice explorer does not reproduce the graphs of Standard Graphs #266

cmspinto opened this issue Jun 19, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@cmspinto
Copy link
Collaborator

cmspinto commented Jun 19, 2024

I picked a random stock and noticed discrepancies between the graphs in SAG and Advice Explorer. For instance, Advice required that SAG not display years without data to avoid misleading users. Could this feature also be implemented in Advice Explorer?

An examples is: https://standardgraphs.ices.dk/ViewCharts.aspx?key=18808

image

Note: It's also missing one of the reference points, this can be read in the web services of SAG.

@cmspinto cmspinto added the bug Something isn't working label Jun 19, 2024
@github-project-automation github-project-automation bot moved this to Technical updates/fixes in adviceXplorer project board Jun 19, 2024
@cmspinto
Copy link
Collaborator Author

Units need also to be checked, here is an example that can be used:
image

@lucalamoni lucalamoni moved this from Technical updates/fixes to In progress in adviceXplorer project board Jul 10, 2024
@lucalamoni lucalamoni moved this from In progress to Review in adviceXplorer project board Jul 22, 2024
@cmspinto
Copy link
Collaborator Author

The Advice explorer is not picking the name of the series. if you look at the series names that the stock coordinator put, it's not being followed by advice explorer.

https://standardgraphs.ices.dk/ViewCharts.aspx?key=18958

In SAG the series is called FMSYproxy
image

in AdviceExplorer it's just called F:

image

Could this be fixed?

@lucalamoni
Copy link
Collaborator

Hi Carlos,
as I mentioned to you in person, the gaps in data (like in the red line) and the custom reference points (like FMSYproxy in blue) are fixed (but the fix is not deployed yet). Colin and I need to review the changes and then I'll deploy the updated app ASAP.
Thank you for spotting this inconsistency.
Cheers
Luca

@cmspinto
Copy link
Collaborator Author

Hi Luca,
Sorry, this looked to me like a new bug.
I would like to call to your attention, that this is not a reference point, it's the name of the series!
Do you think this will be fixed with the next deployment? Can you test this?

@cmspinto
Copy link
Collaborator Author

cmspinto commented Oct 3, 2024

Have noticed there’s a new version of the Advice Explorer, great to see that some of the bugs have been fixed!

Just a quick heads-up: it seems that the units are still incorrect in some areas. For example, in the case of bli.27.5a14, the displayed value is 2500, but in the database, it’s actually 2.5.

Here’s a visual to clarify:

image

image

Could someone take a look at this when you get a chance?

@lucalamoni
Copy link
Collaborator

Hi @cmspinto, yes I fixed some of the issues mentioned above. As you noticed, I still need to fix the units for some stocks (that's why I haven't closed this ticket yet). I already agreed with Laura to meet so that she can explain to me how the units in the graphs are managed in SAG, that way I can adapt a similar method in adviceXplorer.

@lucalamoni
Copy link
Collaborator

lucalamoni commented Oct 14, 2024

@cmspinto In the examples above, the Y-axis units for the SSB plot have been fixed. However, this solution does not work for absolutely all stocks. After the holidays, I still plan to meet with Laura to find a more encompassing solution.

@cmspinto
Copy link
Collaborator Author

Thanks, @lucalamoni If you and Laura need any help, I’m happy to assist. This one is crucial.

@lucalamoni
Copy link
Collaborator

Hi @cmspinto, I corrected the Y-axis units issue listed above. Now the Y-units of the plots in adviceXplorer mirror the ones in SAG (thank you @LApetre for your help with this).
I could find 5 stocks that are still showing some inconsistencies and I have listed them here #288 . In case you find more you are welcome to add to that list. Thank you again for reporting this issue.

@lucalamoni lucalamoni moved this from In progress to Finished tasks in adviceXplorer project board Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Finished tasks
Development

No branches or pull requests

3 participants