-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advice explorer does not reproduce the graphs of Standard Graphs #266
Comments
The Advice explorer is not picking the name of the series. if you look at the series names that the stock coordinator put, it's not being followed by advice explorer. https://standardgraphs.ices.dk/ViewCharts.aspx?key=18958 In SAG the series is called FMSYproxy in AdviceExplorer it's just called F: Could this be fixed? |
Hi Carlos, |
Hi Luca, |
Have noticed there’s a new version of the Advice Explorer, great to see that some of the bugs have been fixed! Just a quick heads-up: it seems that the units are still incorrect in some areas. For example, in the case of bli.27.5a14, the displayed value is 2500, but in the database, it’s actually 2.5. Here’s a visual to clarify: Could someone take a look at this when you get a chance? |
Hi @cmspinto, yes I fixed some of the issues mentioned above. As you noticed, I still need to fix the units for some stocks (that's why I haven't closed this ticket yet). I already agreed with Laura to meet so that she can explain to me how the units in the graphs are managed in SAG, that way I can adapt a similar method in adviceXplorer. |
@cmspinto In the examples above, the Y-axis units for the SSB plot have been fixed. However, this solution does not work for absolutely all stocks. After the holidays, I still plan to meet with Laura to find a more encompassing solution. |
Thanks, @lucalamoni If you and Laura need any help, I’m happy to assist. This one is crucial. |
Hi @cmspinto, I corrected the Y-axis units issue listed above. Now the Y-units of the plots in adviceXplorer mirror the ones in SAG (thank you @LApetre for your help with this). |
I picked a random stock and noticed discrepancies between the graphs in SAG and Advice Explorer. For instance, Advice required that SAG not display years without data to avoid misleading users. Could this feature also be implemented in Advice Explorer?
An examples is: https://standardgraphs.ices.dk/ViewCharts.aspx?key=18808
Note: It's also missing one of the reference points, this can be read in the web services of SAG.
The text was updated successfully, but these errors were encountered: