Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i fixed the code to run with python 3.10 #425

Closed
ghost opened this issue Apr 20, 2022 · 4 comments
Closed

i fixed the code to run with python 3.10 #425

ghost opened this issue Apr 20, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 20, 2022

before i fix the test use cases, i want to make sure someone will take a look at the PR and merge the code.

changes:

life test:

python icloudpd.py --username [email protected] --password 12345678 --directory /Volumes/photos    
2022-04-19 21:24:40 DEBUG    Authenticating...
2022-04-19 21:24:41 DEBUG    Looking up all photos and videos from album All Photos...    
2022-04-19 21:24:41 INFO     Downloading 123724 original photos and videos to /Volumes/photos ...
/Volumes/photos/IMG_0000.JPG already exists.: 100%|#####################################################################################| 123724/123724 [1:27:33<00:00, 23.55it/s]
2022-04-19 22:52:14 INFO     All photos have been downloaded!
@martin-juul
Copy link

Can you make a fork with the changes?

@ghost
Copy link
Author

ghost commented May 23, 2022

forked and updated with new code: https://github.com/scurvylogs/icloud_photos_downloader

@AndreyNikiforov
Copy link
Collaborator

@ghost is your switching off pyicloud fork is similar to #528 ?

@AndreyNikiforov
Copy link
Collaborator

We have support for python 3.7..3.11 in 1.8.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants