Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed builtin pyicloud and use pyicloud with China domain fix. #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derekhe
Copy link

@derekhe derekhe commented Mar 17, 2023

I removed the built-in pyicloud and use latest pyicloud with China domain fix and it is working now.
Unfortunately the tests can't pass and I don't know how to fix them.

Tests are broken and can't be fixed in short time.
@zcoderr
Copy link

zcoderr commented Jun 15, 2023

@derekhe It's doesn't work.

2023-06-15 09:46:37 DEBUG Authenticating...
iCloud Password:
Traceback (most recent call last):
File "/workspaces/icloud_photos_downloader/exec.py", line 63, in
commands()
File "/home/vscode/.local/lib/python3.11/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.11/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.11/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.11/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.11/site-packages/click/core.py", line 760, in invoke
return _callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/workspaces/icloud_photos_downloader/icloudpd/base.py", line 288, in main
core(
File "/workspaces/icloud_photos_downloader/icloudpd/base.py", line 572, in core
icloud = authenticator(domain)(
^^^^^^^^^^^^^^^^^^^^^^
File "/workspaces/icloud_photos_downloader/icloudpd/authentication.py", line 35, in authenticate

icloud = pyicloud.PyiCloudService(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.11/site-packages/pyicloud/base.py", line 279, in init
self.authenticate()
File "/home/vscode/.local/lib/python3.11/site-packages/pyicloud/base.py", line 345, in authenticate
self._webservices = self.data["webservices"]
~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'webservices'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants