Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional dependencies and deprecated functions #18

Open
skarrea opened this issue Apr 7, 2023 · 2 comments
Open

Additional dependencies and deprecated functions #18

skarrea opened this issue Apr 7, 2023 · 2 comments

Comments

@skarrea
Copy link

skarrea commented Apr 7, 2023

Hey and thanks for a great repository.
While setting the code up I found that some of the dependencies were missing from the readme.
Specifically, these are scikit-image, h5py and ml_collections.

Additionally, in more recent versions of scikit-image, compare_psnr is moved and renamed from skimage.measure.compare_psnr to skimage.metrics.peak_signal_noise_ratio.

In more recent versions of pytorch it also seems that the .cuda(async = ...) keyword is replaced with .cuda(non_blocking = ... ) since async is a reserved keyword in python >= 3.7.

I see two ways to fix the issues; either by being more specific in terms of compatible package versions or, my preferred solution, updating the codebase to new keywords and functions.

I'd gladly submit a pull request with the mentioned changes if you'd like me to.
I also made a dockerfile for setting up an environment with the requirements if that should be of any interest.

@skarrea
Copy link
Author

skarrea commented Apr 7, 2023

I also found that scipy.misc.imresize is deprecated since version 1.3.0 and Image.resize from pillow is suggested to be used instead. And scipy should perhaps also be added as a dependency.

@kaiyuxin
Copy link

You mentioned that you have also debugged the ResViT model, and I have a question for you. I have successfully trained the model, but when I test it, no images are output after running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants