Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batching courses and instructors is broken #107

Closed
laggycomputer opened this issue Feb 3, 2025 · 0 comments · Fixed by #108
Closed

Batching courses and instructors is broken #107

laggycomputer opened this issue Feb 3, 2025 · 0 comments · Fixed by #108

Comments

@laggycomputer
Copy link
Member

Due to the reordering of routes in #101 to put courseByIdRoute before batchCourses (and similarly for instructors), the batch endpoints are now masked as the /{id} now consumes the /batch, trying to fetch a course/instructor by ID batch. This is clearly not right.

Currently breaking PeterPortal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hotfix(courses,instructors): correct batch route precedence icssc/anteater-api
1 participant
@laggycomputer