Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate nuclear data from the concept of an Isotope #112

Open
MicahGale opened this issue Oct 31, 2022 · 3 comments · May be fixed by #608
Open

Separate nuclear data from the concept of an Isotope #112

MicahGale opened this issue Oct 31, 2022 · 3 comments · May be fixed by #608
Assignees
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users.
Milestone

Comments

@MicahGale
Copy link
Collaborator

Right now the Isotope object both represents an isotope, but also a specific set of nuclear data representing that isotope (e.g., the 1001.80c ACE data). This is complicating things and muddying the water. Isotopes need to be sovereign and independent of the nuclear data (but probably really should represent an isomer). Then a nuclear data object (name TBD) can wrap that isotope inside a specific nuclear data library at a specific temperature.

This complicated my life because when adding metastable isomers to the Isotope object (#70) I wanted to add a function: def get_base_isotope(self): -> Isotope however with the nuclear data library information this function can have weird consequences and therefore has been tabled for the time being.

@MicahGale
Copy link
Collaborator Author

marked this issue as related to #14

@tjlaboss
Copy link
Collaborator

Should this also be separated from the concept of an isomer (#486)?

@MicahGale
Copy link
Collaborator Author

I'm not sure. With the branch mat_redesign this might be a null concern.

@MicahGale MicahGale mentioned this issue Sep 17, 2024
35 tasks
@MicahGale MicahGale self-assigned this Sep 17, 2024
@MicahGale MicahGale modified the milestones: Summer-sprint, 1.0.0-alpha Nov 8, 2024
@MicahGale MicahGale linked a pull request Dec 5, 2024 that will close this issue
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants