Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce MCNP number limits #31

Open
MicahGale opened this issue Apr 8, 2022 · 6 comments
Open

Enforce MCNP number limits #31

MicahGale opened this issue Apr 8, 2022 · 6 comments
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface.

Comments

@MicahGale
Copy link
Collaborator

MCNP has some (rather infuriating) limitations on the numbers allowed for objects. These limits should be enforced.

@MicahGale
Copy link
Collaborator Author

created branch 24-enforce-mcnp-number-limits to address this issue

@MicahGale
Copy link
Collaborator Author

In GitLab by @tjlaboss on Aug 5, 2022, 17:55

Unusual number limits according to the manual:

  • The number of tallies may not exceed 9999 (Sections 1.3.4.4, 3.3.5.1).
  • Allowed surface numbers for transformations and repeated structures: 1-999
  • Allowed cell numbers for transformations: 1-999
  • Surface transformations: 1-999 (no limit for cell transformations)
  • Allowed cell and surface numbers for traditional formatting for MCTAL file: 99,999

@MicahGale
Copy link
Collaborator Author

I do have some of this in the MR already. The issue is that some of these aren't enforced, and can sometimes run.

@MicahGale
Copy link
Collaborator Author

So I think the only numbers that actually may cause an issue is when a cell is transformed, and new surfaces are made.

@MicahGale
Copy link
Collaborator Author

Se re: Tally. I have exceeded 9999 before. Also in section 3.3.5.1 "The tally number may not exceed 99,999,999".

@MicahGale
Copy link
Collaborator Author

With how complex this is, I'm booting this to be another release. I think what we really need first is to make virtual surfaces for transformed cells, which will be its own big thing see: #56, #68.

@MicahGale MicahGale self-assigned this Jan 12, 2024
@MicahGale MicahGale removed their assignment Feb 6, 2024
@MicahGale MicahGale removed this from the Release-1.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface.
Projects
None yet
Development

No branches or pull requests

1 participant