Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce concept of Submaterials #535

Open
MicahGale opened this issue Sep 5, 2024 · 2 comments
Open

Introduce concept of Submaterials #535

MicahGale opened this issue Sep 5, 2024 · 2 comments
Labels
feature request An issue that improves the user interface. low priority

Comments

@MicahGale
Copy link
Collaborator

MicahGale commented Sep 5, 2024

Speaking to @dodu94 this concept came up.

Sometimes users will create "mixtures" in a material definition. e.g.,

c water and boric acid
m1 
c water
     1001.80c 0.66665
     8016.80c 0.3300
c boric acid
     1001.80c 3e-6
     8016.80c 3e-6
     5010.80c 1e-6

So sometimes it would be helpful to be able to isolate these separate constituents of the material mixture.

The main question is what condition should distinguish a submaterial, @dodu94?

I think you really only have two options:

  1. Create a new submaterial with any "splitting comment"
  2. Create some sort of comment syntax (à la Creating an embedded syntax in MCNP comments #344). Personally I think this is a risky approach, and I am very hesitant to introduce anything along these lines.
@MicahGale MicahGale added the feature request An issue that improves the user interface. label Sep 5, 2024
@dodu94
Copy link

dodu94 commented Sep 6, 2024

The example you are showing is the approach I am taking but I recognize that this cannot be implemented in a general parser such as montepy. I guess the only two valid options are either not supporting sub-materials or going for a special montepy comment syntax

@MicahGale
Copy link
Collaborator Author

I think we just made the sub materials for any comment and named them according to the comment that would work. No customer syntax. If the user wants to use it is there, and they can tweak their comments accordingly. Otherwise it would be just be a normal material.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request An issue that improves the user interface. low priority
Projects
None yet
Development

No branches or pull requests

2 participants