Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set verify_holes to false in RGMB FlexiblePatternGenerator mesh subgenerator calls #28316

Closed
shikhar413 opened this issue Aug 6, 2024 · 1 comment
Closed

Set verify_holes to false in RGMB FlexiblePatternGenerator mesh subgenerator calls #28316

shikhar413 opened this issue Aug 6, 2024 · 1 comment
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@shikhar413
Copy link
Contributor

Bug Description

https://civet.inl.gov/job/2367026/ - reactor module test failure, likely due to the fact that verify_holes is set to true by default in the mesh subgenerator call

Steps to Reproduce

See https://civet.inl.gov/job/2367026/

Impact

Pass tests for devel branch

[Optional] Diagnostics

No response
@shikhar413 shikhar413 added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Aug 6, 2024
@shikhar413 shikhar413 mentioned this issue Aug 6, 2024
Merged
GiudGiud pushed a commit that referenced this issue Aug 6, 2024
@shikhar413
Set verify_holes to false in FPG subgenerator call, refs #28316
e80e72d
jmeier added a commit to jmeier/moose that referenced this issue Aug 7, 2024
@jmeier
[Physics/SolidMechanics/QuasiStatic]: add displacement variables with…
7cb5ba2 
… block restriction

closes idaholab#28307

Add a none fail mode to terminator, refs idaholab#28273

Add test for new terminator (no)fail mode, closes idaholab#28273

Differentiate the two enums in the terminator

Improvements to position definitions in AverageSectionValueSampler

1) Deprecate 'lengths' parameter in favor of more descriptive
   'positions'
2) If 'positions' are not defined, automatically define positions
   based on locations of nodes in the component.
3) Generate an error (which can be overridden) if the number of nodes
   at each position varies. This is to avoid errors that might be
   encountered due to tolerances in locating nodes at a position.
4) Add an output vector with the axial positions.

Add tests for new capabilities in AverageSectionValueSampler ref idaholab#28227

* Parameter specification errors
* Automatic position determination
* Automatic position determination with an adapting mesh
* Errors if equal numbers of nodes at positions are required

Update documentation for new features in AverageSectionValueSampler ref idaholab#28227

Apply suggestions from code review

Co-authored-by: Jason Hales <[email protected]>

added BlockRestrictionDebugOutput
closes idaholab#28290

Set verify_holes to false in FPG subgenerator call, refs idaholab#28316
jmeier added a commit to jmeier/moose that referenced this issue Aug 7, 2024
@jmeier
[Physics/SolidMechanics/QuasiStatic]: add displacement variables with…
222b554 
… block restriction

closes idaholab#28307

Add a none fail mode to terminator, refs idaholab#28273

Add test for new terminator (no)fail mode, closes idaholab#28273

Differentiate the two enums in the terminator

Improvements to position definitions in AverageSectionValueSampler

1) Deprecate 'lengths' parameter in favor of more descriptive
   'positions'
2) If 'positions' are not defined, automatically define positions
   based on locations of nodes in the component.
3) Generate an error (which can be overridden) if the number of nodes
   at each position varies. This is to avoid errors that might be
   encountered due to tolerances in locating nodes at a position.
4) Add an output vector with the axial positions.

Add tests for new capabilities in AverageSectionValueSampler ref idaholab#28227

* Parameter specification errors
* Automatic position determination
* Automatic position determination with an adapting mesh
* Errors if equal numbers of nodes at positions are required

Update documentation for new features in AverageSectionValueSampler ref idaholab#28227

Apply suggestions from code review

Co-authored-by: Jason Hales <[email protected]>

added BlockRestrictionDebugOutput
closes idaholab#28290

Set verify_holes to false in FPG subgenerator call, refs idaholab#28316
@GiudGiud
Copy link
Contributor

GiudGiud commented Aug 9, 2024

closing as addressed by #28317

@GiudGiud GiudGiud closed this as completed Aug 9, 2024
TheGreatCid pushed a commit to TheGreatCid/moose that referenced this issue Aug 14, 2024
@shikhar413 @TheGreatCid
Set verify_holes to false in FPG subgenerator call, refs idaholab#28316
91f0b7b
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@shikhar413
Set verify_holes to false in FPG subgenerator call, refs idaholab#28316
ec41813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shikhar413 @GiudGiud