Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Convergence object checks aware of solve type #28927

Open
joshuahansel opened this issue Oct 24, 2024 · 0 comments
Open

Make Convergence object checks aware of solve type #28927

joshuahansel opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Motivation

The Convergence system in #28848 introduces Convergence objects with a checkConvergence() method. These objects are planned to work in several different contexts, such as:

  • nonlinear solves
  • steady-state detection
  • fixed point solves

Some implementations of checkConvergence() will need to know which of these context the object is being used in, or at least throw an error if used in an ineligible context.

Design

A possible solution is to pass some kind of IterationType parameter to checkConvergence(), which could have values like IterationType::Nonlinear. It would be ideal to be able to have an extensible list of iteration types, but this is not essential.

Impact

Possible API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
Development

No branches or pull requests

1 participant