Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on convergence when using Picard iterations #29252

Open
moosebuild opened this issue Dec 4, 2024 · 0 comments
Open

Decide on convergence when using Picard iterations #29252

moosebuild opened this issue Dec 4, 2024 · 0 comments
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module imported

Comments

@moosebuild
Copy link
Contributor

Imported from https://github.inl.gov/ncrc/subchannel/issues/58 : @moose-ncrc created issue at Feb 21, 2022 09:12AM MST:

In GitLab by @andrsd on Feb 21, 2022, 09:12

Description of the enhancement

Compute residual for p, T. Use that to decide on convergence of a Picard (fixed point) iteration.

Rationale for the enhancement

When doing Picard iterations, MOOSE considers only primary variables, thus it reports 0. for subchannel solves. If we can feed the residual from subchannel into the Executioner, then we can control convergence criteria as in a usual MOOSE-based app.

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)

Gain functionality, better usability.

Notes

  • Since subchannel use p and T, this may be a little more challenging to implement, since MOOSE decides on convergence using only a single value.
@moosebuild moosebuild added C: Modules/Subchannel Tickets pertaining to the subchannel module imported labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module imported
Projects
None yet
Development

No branches or pull requests

1 participant