From 507125c637a75a4aca464fc649e64ee5a3acfce5 Mon Sep 17 00:00:00 2001 From: ditoglez Date: Fri, 29 Nov 2024 19:35:32 +0200 Subject: [PATCH] feat(client-sdk): allow to pass `synchronous` flag for kwil executions (#367) --- packages/idos-sdk-js/src/lib/data.ts | 15 ++++++++++----- packages/idos-sdk-js/src/lib/kwil-wrapper.ts | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/idos-sdk-js/src/lib/data.ts b/packages/idos-sdk-js/src/lib/data.ts index 2f3032975..bce1570f3 100644 --- a/packages/idos-sdk-js/src/lib/data.ts +++ b/packages/idos-sdk-js/src/lib/data.ts @@ -292,6 +292,7 @@ export class Data { tableName: string, recordId: string, receiverPublicKey: string, + synchronous?: boolean, ): Promise<{ id: string }> { const name = this.singularize(tableName); @@ -322,17 +323,21 @@ export class Data { }, ], `Share a ${name} on idOS`, - true, + synchronous, ); return { id }; } - async unshare(tableName: string, recordId: string): Promise<{ id: string }> { - return await this.delete(tableName, recordId); + async unshare( + tableName: string, + recordId: string, + synchronous?: boolean, + ): Promise<{ id: string }> { + return await this.delete(tableName, recordId, undefined, synchronous); } - async addWriteGrant(grantee: string) { + async addWriteGrant(grantee: string, synchronous?: boolean) { return await this.kwilWrapper.execute( "add_write_grant", [ @@ -341,7 +346,7 @@ export class Data { }, ], `Grant ${grantee} write access to your idOS credentials`, - true, + synchronous, ); } diff --git a/packages/idos-sdk-js/src/lib/kwil-wrapper.ts b/packages/idos-sdk-js/src/lib/kwil-wrapper.ts index 2d3a4c74a..0ffbf5bf1 100644 --- a/packages/idos-sdk-js/src/lib/kwil-wrapper.ts +++ b/packages/idos-sdk-js/src/lib/kwil-wrapper.ts @@ -116,7 +116,7 @@ export class KwilWrapper { actionName: string, actionInputs: Record[], description?: string, - synchronous?: boolean, + synchronous = true, ) { if (!this.signer) throw new Error("No signer set");