Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGF2MSP connverter breaks SMILES codes #1

Open
tobigithub opened this issue Aug 8, 2024 · 1 comment
Open

MGF2MSP connverter breaks SMILES codes #1

tobigithub opened this issue Aug 8, 2024 · 1 comment

Comments

@tobigithub
Copy link

tobigithub commented Aug 8, 2024

The current implementation of the IDSL.FSA mgf2msp function breaks SMILES, probably because the escape characters are not correctly handled. Also for some compounds the SMILES code is completely transformed, which should not be the case for a simple format converter, unless explicitly requested in a function call.

mgf2msp(path = temp_wd, MGFfile_name)

For diverse inputs SMILES the error rate can can be 50% or higher. Example:

MGF:
SMILES=Brc1cc2c(cc1/C=N/c1c(-c3ccco3)nc3ccccn13)OCO2
MSP:
SMILES: Brc1cc2c(cc1/C: N/c1c(-c3ccco3)nc3ccccn13)OCO2

observe the C=N is converted to C: N (with space). Outputs have to be checked via InChIKey.

tester.msp.txt
tester.mgf.txt

More example files are here.

@barupal
Copy link
Member

barupal commented Aug 9, 2024

Thanks, Tobias. We will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants