Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The holder's signature needs to also incorporate the presented proof" #94

Open
dwaite opened this issue Jan 9, 2024 · 1 comment
Open
Assignees
Labels
JPA JSON Proof Algorithms
Milestone

Comments

@dwaite
Copy link
Collaborator

dwaite commented Jan 9, 2024

In review, we interpreted this old comment as the presentation proof needs to sign over the entire derived message (issuer header and presented payloads) rather than just the header. this changes the SU and MAC based algorithms.

@dwaite dwaite self-assigned this Jan 9, 2024
@dwaite dwaite added the JPA JSON Proof Algorithms label Jan 9, 2024
@dwaite dwaite added this to the draft-3 milestone Feb 20, 2024
@dwaite
Copy link
Collaborator Author

dwaite commented Feb 20, 2024

I will evaluate as part of my work on resolving #59

@dwaite dwaite modified the milestones: draft-3, draft-4 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JPA JSON Proof Algorithms
Projects
None yet
Development

No branches or pull requests

1 participant