diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3fe7be5..a464961 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp` -# using RuboCop version 1.56.3. +# using RuboCop version 1.57.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -25,7 +25,7 @@ Metrics/MethodLength: # Configuration parameters: CountComments, CountAsOne. Metrics/ModuleLength: - Max: 142 + Max: 143 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: @@ -125,12 +125,6 @@ Style/MultipleComparison: Style/NumericLiterals: MinDigits: 6 -# This cop supports safe autocorrection (--autocorrect). -Style/ParallelAssignment: - Exclude: - - 'lib/chrono_model/adapter/ddl.rb' - - 'lib/chrono_model/time_machine.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: RequireEnglish, EnforcedStyle. # SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names diff --git a/lib/chrono_model/adapter/ddl.rb b/lib/chrono_model/adapter/ddl.rb index 7ef84db..d348866 100644 --- a/lib/chrono_model/adapter/ddl.rb +++ b/lib/chrono_model/adapter/ddl.rb @@ -42,7 +42,8 @@ def chrono_public_view_ddl(table, options = nil) columns = self.columns(table).map { |c| quote_column_name(c.name) } columns.delete(quote_column_name(pk)) - fields, values = columns.join(', '), columns.map { |c| "NEW.#{c}" }.join(', ') + fields = columns.join(', ') + values = columns.map { |c| "NEW.#{c}" }.join(', ') chrono_create_INSERT_trigger(table, pk, current, history, fields, values) chrono_create_UPDATE_trigger(table, pk, current, history, fields, values, options, columns) diff --git a/lib/chrono_model/time_machine.rb b/lib/chrono_model/time_machine.rb index bb5aece..66b96f1 100644 --- a/lib/chrono_model/time_machine.rb +++ b/lib/chrono_model/time_machine.rb @@ -236,7 +236,8 @@ def last_changes # def changes_against(ref) self.class.attribute_names_for_history_changes.inject({}) do |changes, attr| - old, new = ref.public_send(attr), public_send(attr) + old = ref.public_send(attr) + new = public_send(attr) changes.tap do |c| changed =