Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More visible Multiple lines assignment #16

Open
iamariffikri opened this issue May 23, 2017 · 1 comment
Open

More visible Multiple lines assignment #16

iamariffikri opened this issue May 23, 2017 · 1 comment

Comments

@iamariffikri
Copy link

It is my format preference to add tab spacing when it comes to multiple lines of assignment. To my personal view, it's much clearer to keep eyes on the values and keys involved also less eye-strain.

Nonetheless I understand if the style is not really in favour of the team. Would love to see how apple team poll on this. Leave 👍🏼 or 👎🏼 and we'll take it to styleguide or drop it.

contextData[AdobeMobileContextKey.appPageName.rawValue]     = AdobeMobileScreenName.player.rawValue
contextData[AdobeMobileContextKey.appAssetId.rawValue]      = contentIdString
contextData[AdobeMobileContextKey.appAssetGenre.rawValue]   = contentTypeString
contextData[AdobeMobileContextKey.appPlayLink.rawValue]     = 1
contextData[AdobeMobileContextKey.appCategory.rawValue]     = category
contextData[AdobeMobileContextKey.appSubCategory.rawValue]  = subcategory
contextData[AdobeMobileContextKey.appType.rawValue]         = "app"
contextData[AdobeMobileContextKey.appLanguage.rawValue]     = App.userInfo.language
@mokagio
Copy link
Contributor

mokagio commented May 23, 2017

I think in a case such as the one that you presented above the style makes sense.

My question would be though: how do we choose when to use this? Is there a minimum number of lines after which we should do it? Do they have to be it that kind of style (i.e. dictionary key-value settings) or does this hold true for any list of foo = bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants