Indentation

[mokagio]

2 spaces vs 4 spaces? 🔥 🍿

[cuteiosdev]

I have a preference for 2 spaces, though the majority of the project uses 4. If we do make the decision to move to 2 spaces (which is my preference) we'll need to reformat all the files and that'll mean loosing history to a large extent.

As such, though it irks me, I think staying with 4 is best for now.

[mokagio]

I'm of the same opinion, 2 spaces are much more compact, and work very well with Swift.

I'd like to point out that we would not really loose the history, but just add an extra commit on the history. This would adds some friction when blaming (you'd see that the last edit was done by the reformat commit, and then have to actually log all the commits on the file in question), but would be smoothed out in the short-mid term, at least for the files that don't change much.

I would like to keep the discussion open, we'll be implementing monorepo soon, which will mean add a whole bunch of code without history. It might be a good point in which to perform the change (since we're messing up let's do it properly 😄).

On the other hand, the pragmatic approach would be to behave like grown ups and just deal with the 4 spaces 😳 .

[nhisyam]

I'm neutral over this. Will go with majority vote.

[TimKregerIflix]

I'm easy, have been involved in too many pitched battles to care!

[adriaan]

I don't have strong opinions about this. Though 4 spaces provide a stronger signal to not write deeply nested code.

[mokagio]

Though 4 spaces provide a stronger signal to not write deeply nested code.

Nice way to look at it 😄 . I'd actually be happy to adopt it with this rational 🤔 .