Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function returning git revision #390

Open
pdziekan opened this issue Dec 23, 2019 · 1 comment
Open

Function returning git revision #390

pdziekan opened this issue Dec 23, 2019 · 1 comment

Comments

@pdziekan
Copy link
Contributor

Currently, git revision of libcloudphxx is stored in a header file.
Software that dynamically loads libcloudphxx (e.g. UWLCM) needs to be recompiled after new version of libcloudph++ is installed in order to output proper git revision of libcloudph++.

This could be improved if libcloudph++ defined a function returning the git revision.

@slayoo
Copy link
Collaborator

slayoo commented Dec 23, 2019

I concur this would be useful, but rather to implement a "you are dynamically linking with different version of libcloudph++ than UWLCM was compiled against" warning (or error).

The point is that when compiling UWLCM with libcloudph++ headers, some constants or even more elaborate logic gets compiled into the UWLCM binaries (e.g., p_vs(T) function). Now, imagine libcloudph++ gets a new implementation of p_vs(T) - then the case definition would be inconsistent with what is happening while time-stepping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants