Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2905: Update Maven Wrapper to 3.3.2 #2593

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Nov 11, 2024

These changes are the result of executing ./mvnw wrapper:wrapper

@guusdk guusdk requested a review from Fishbowler November 11, 2024 16:20
@guusdk
Copy link
Member Author

guusdk commented Nov 11, 2024

Weird that it removes the JAR file.

@guusdk guusdk force-pushed the OF-2905_Maven-wrapper-3.6.3 branch 2 times, most recently from 76e742a to c1e9161 Compare November 11, 2024 16:22
@guusdk guusdk changed the title OF-2905: Update Maven Wrapper to 3.6.3 OF-2905: Update Maven Wrapper to 3.3.2 Nov 11, 2024
@Fishbowler
Copy link
Member

Weird that it removes the JAR file.

This is the only-script way, and is apparently the default now. https://maven.apache.org/wrapper/

@Fishbowler
Copy link
Member

There's a second maven wrapper in build/ci/updater.
Ideally, I'd find a way to integrate this more neatly. In the meantime, I'm struggling to get ./mvnw wrapper:wrapper to generate something similar to the root version, even down to the version of the wrapper in use :(

These changes are the result of executing:
```
./mvnw wrapper:wrapper ./mvnw wrapper:wrapper -Dtype=bin
cd build/ci/updater/
export OPENFIREVSN=5.0.0-SNAPSHOT && ./mvnw wrapper:wrapper -Dtype=bin
```
@guusdk guusdk force-pushed the OF-2905_Maven-wrapper-3.6.3 branch from c1e9161 to 9b868c9 Compare November 12, 2024 08:27
@guusdk
Copy link
Member Author

guusdk commented Nov 12, 2024

Oh, that's a good find. I've got a slight preference for not changing the type of wrapper that we used, so I'll re-generate with

./mvnw wrapper:wrapper ./mvnw wrapper:wrapper -Dtype=bin

Within build/ci/updater/ I'll try to do the same thing. It appears that we need an explicit environment variable for that plan to work. I've tried with the following from within that directory:

export OPENFIREVSN=5.0.0-SNAPSHOT && ./mvnw wrapper:wrapper -Dtype=bin

@Fishbowler
Copy link
Member

Approved but not merged, given all the activity currently happening in the project and its plugins.

Merge whenever you're ready for it, Guus.

@guusdk guusdk merged commit 2404da1 into igniterealtime:main Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants