Initial support for XEP-0446: File Metadata Element #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flowdalic
requested changes
Jan 6, 2021
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
...xperimental/src/test/java/org/jivesoftware/smackx/file_metadata/FileMetadataElementTest.java
Outdated
Show resolved
Hide resolved
Flowdalic
requested changes
Jan 10, 2021
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
| private final Date date; | ||
| private final String dimensions; | ||
| private final Map<String, String> descriptions = new ConcurrentHashMap<>(); | ||
| private final Map<HashManager.ALGORITHM, HashElement> hashElements = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
As above: This should not need to use ConcurrentHashMap.
Furthermore, don't we have support for XEP-0300 in Smack? If so, then there should be a Class for the <hash xmlns='urn:xmpp:hashes:2'/> element. If not, then we should add such a Class and use it there.
There was a problem hiding this comment.
I'm not sure I understand this comment. HashElement is already from Smacks XEP-0300 implementation.
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
Flowdalic
reviewed
Jan 12, 2021
...imental/src/main/java/org/jivesoftware/smackx/file_metadata/element/FileMetadataElement.java
Outdated
Show resolved
Hide resolved
Flowdalic
requested changes
Dec 7, 2023
vanitasvitae
force-pushed
the
file_metadata
branch
from
0fea306
to
e2b2752
Compare
Also adds initial support for XEP-0264: Jingle Content Thumbnails Solves SMACK-894
vanitasvitae
force-pushed
the
file_metadata
branch
from
e2b2752
to
441d677
Compare
|
Thanks, please see also my follow-up commit b5180f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves SMACK-894
XEP-0446: File Metadata Element defines a generic extension element format that can be used to describe file metadata.
This PR adds initial support for this protocol by implementing the element and provider classes.