Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Req] Notification should not override users' settings by default #74

Open
xiota opened this issue Sep 10, 2023 · 5 comments
Open

Comments

@xiota
Copy link

xiota commented Sep 10, 2023

Output of bubblejail --version

0.8.1 / 806acc9

Your distro name and version

Arch Linux

Description

Currently, notification urgency is set to critical, which overrides users' notification settings, making the notification permanent until manually dismissed by the user. Overriding users' settings is at best annoying and should not be done.

Removing the urgency setting would respect users' existing settings, allowing the notification to timeout normally. Making urgency level configurable would also resolve this issue, but depending on notification manager, may be unnecessary.

If the notification is needed after it has been dismissed, most notification managers have a history that can be reviewed.

Some notification managers have per application settings. However, it cannot be used to work around this issue because bubblejail notifications are not separated from the sandboxed apps and critical urgency overrides it.

Relevant: #65 (comment), #73

@igo95862
Copy link
Owner

The reason I prefer the critical level is because bubblejail failing to run is something that should be exceedingly rare and it should be "in your face". The user might be frustrated if they don't understand why an application is not doing anything.

You case is pretty special because of missing network interface.

@igo95862
Copy link
Owner

For example, critical urgency goes through the GNOME's Do Not Disturb mode which I consider as desired behavior.

The goal is to never leave user guessing.

@xiota
Copy link
Author

xiota commented Sep 11, 2023

Users who have enabled the "Do Not Disturb" setting do not want to be disturbed, for whatever reason. It's not respectful to those users to override their preferences. You don't know their circumstances, what you're disrupting, what the consequences are.

If an application silently doesn't start for some period of time, it's obvious something failed. This happens all the time, such as with segfaults. In case of failure, running bubblejail in a terminal is still necessary to view the errors because the notification doesn't contain the full output.

@igo95862
Copy link
Owner

Notification standard: https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#urgency-levels

Critical notifications should not automatically expire, as they are things that the user will most likely want to know about.

I am planning on making the notification level configurable (by instance or globally) but I don't see anything wrong with using critical level by default.

@xiota
Copy link
Author

xiota commented Sep 14, 2023

I am planning on making the notification level configurable...

I look forward to it. In the meantime, it's been annoying enough that I've started patching it out of my builds.

I don't see anything wrong with using critical level by default.

What's wrong is the notifications aren't actually "critical" to anyone who isn't a developer. The default should be to respect users' preferred settings.

Critical notifications... are things that the user will most likely want to know about.

Right. Only developers would "most likely want to know about" the contents of those notifications. Normal users won't care.

@xiota xiota changed the title Notification should not override users' settings by default [Bug/Req] Notification should not override users' settings by default Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants