From e85ee3e38d6adbe01193a7e4a33b4a3be7932eae Mon Sep 17 00:00:00 2001 From: Ketan Reynolds Date: Wed, 1 May 2024 21:00:33 +0200 Subject: [PATCH] std.posix: handle INVAL in openZ and openatZ Contributes to #15607 Although the case is not handled in `openatWasi` (as I could not get a working wasi environment to test the change) I have added a FIXME addressing it and linking to the issue. --- lib/std/posix.zig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/std/posix.zig b/lib/std/posix.zig index 36486bd1b694..ab33d7799fd3 100644 --- a/lib/std/posix.zig +++ b/lib/std/posix.zig @@ -1598,7 +1598,7 @@ pub fn openZ(file_path: [*:0]const u8, flags: O, perm: mode_t) OpenError!fd_t { .INTR => continue, .FAULT => unreachable, - .INVAL => unreachable, + .INVAL => return error.BadPathName, .ACCES => return error.AccessDenied, .FBIG => return error.FileTooBig, .OVERFLOW => return error.FileTooBig, @@ -1676,6 +1676,9 @@ pub fn openatWasi( .INTR => continue, .FAULT => unreachable, + // FIXME: It is worth looking into returning a `error.BadPathName` + // here if wasi follows other posix behavior + // see: https://github.com/ziglang/zig/issues/15607 .INVAL => unreachable, .BADF => unreachable, .ACCES => return error.AccessDenied, @@ -1767,7 +1770,7 @@ pub fn openatZ(dir_fd: fd_t, file_path: [*:0]const u8, flags: O, mode: mode_t) O .INTR => continue, .FAULT => unreachable, - .INVAL => unreachable, + .INVAL => return error.BadPathName, .BADF => unreachable, .ACCES => return error.AccessDenied, .FBIG => return error.FileTooBig,