-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to a modern .NET version (8.0) #76
Comments
Thanks for doing this. .NET 8.0 would be a good step towards having a cross-platform IP version. Also, would make running the tests easier since we can use dotnet instead of having to use a patched version of Microsoft's VSTest action (it's been broken for two months but they haven't fixed it :V) Would also be nice to see that Assimp bug fixed. The latest version is a prerelease so hopefully there's no new bugs in it - that would require some testing. Possible downsides are:
|
There is actually a more recent fork of assimpnet: Perhaps we could use that one instead. |
Yea we should not target Windows 7/8 support and the Windows 10 update 1607 is from 2016 so that should be fine too. The Assimp.Net package does target a newer version (5.2.5 vs. 5.0.0) but throws an error trying to import/export a model on my end: "The specified module could not be found. (0x8007007E)", even though the module (assimp.dll) does exist in the specified path. Taking a look at this we should be fine, I think: https://learn.microsoft.com/en-us/dotnet/core/porting/ I would consider switching to .NET 8 after the next IP release anyway so waiting for a rider update is fine too. |
I have created a branch where IndustrialPark and its subprojects have been successfully updated to .NET 8.0. This also includes following additional changes:
SharpDX.Desktop
to the latest compatible version.AssimpNet
to the latest compatible version (fixes DAE vertex colours are incorrect due to an Assimp.net bug #54 and adds more features like *.fbx export)Testing:
I have tested the updated branch and ensured that all existing tests pass successfully. However, additional testing would be beneficial to ensure full compatibility.
The text was updated successfully, but these errors were encountered: