ref-qualify move assignments for improved safety

igraph · Jul 29, 2024 · c746348 · c746348
1 parent 69f77dd
commit c746348
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/include/graph.hpp b/include/graph.hpp
@@ -42,7 +42,7 @@ class Graph {
 
     Graph & operator = (const Graph &) = delete;
 
-    Graph & operator = (Graph &&other) noexcept {
+    Graph & operator = (Graph &&other) && noexcept {
         if (! is_alias())
             igraph_destroy(ptr);
         if (other.is_alias()) {

diff --git a/include/mat_pmt.hpp b/include/mat_pmt.hpp
@@ -51,7 +51,7 @@ template<> class Mat<OBASE> {
         return *this;
     }
 
-    Mat & operator = (Mat &&other) noexcept {
+    Mat & operator = (Mat &&other) && noexcept {
         if (! is_alias())
             FUNCTION(igraph_matrix, destroy)(ptr);
         if (other.is_alias()) {

diff --git a/include/typed_list_pmt.hpp b/include/typed_list_pmt.hpp
@@ -6,7 +6,7 @@ template<>
 #endif
 class LIST_TYPE_TEMPL {
     template<typename ValueType, typename Reference> class base_iterator;
-    
+
 public:
     using igraph_type = TYPE;
 
@@ -46,7 +46,7 @@ class LIST_TYPE_TEMPL {
 
     LIST_TYPE & operator = (const LIST_TYPE &other) = delete;
 
-    LIST_TYPE & operator = (LIST_TYPE &&other) noexcept {
+    LIST_TYPE & operator = (LIST_TYPE &&other) && noexcept {
         if (! is_alias())
             FUNCTION(destroy)(ptr);
         if (other.is_alias()) {

diff --git a/include/vec_pmt.hpp b/include/vec_pmt.hpp
@@ -63,7 +63,7 @@ template<> class Vec<OBASE> {
         return *this;
     }
 
-    Vec & operator = (Vec &&other) noexcept {
+    Vec & operator = (Vec &&other) && noexcept {
         if (! is_alias())
             FUNCTION(igraph_vector, destroy)(ptr);
         if (other.is_alias()) {