Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to same visibility level when replying #510

Open
snan opened this issue Nov 23, 2024 · 2 comments
Open

Default to same visibility level when replying #510

snan opened this issue Nov 23, 2024 · 2 comments

Comments

@snan
Copy link
Contributor

snan commented Nov 23, 2024

I want it to default to the same visibility level when replying (but being able to over ride it with -v). I seem to recall it worked like that up to very recently.

@ihabunek
Copy link
Owner

So, I think I found the cause of this regression in commit 125626d where I missed the fact that it sets the default value for visibility to public. I have corrected it so that visibility is not sent to the server when posting, unless the --visibility option is used explicitly. That way the server decides what's the visibility, e.g. if user has a default visibility set to something other than public.

That being said, this does not fix the issue for me on Mastodon. It seems that Mastodon sets the visibility to public by default, even when replying to a post which is not public. Please test on your server and see if it fixes it for you.

This could be fixed by first fetching the post we're replying to, reading it's visibility, and then posting using that visibility. I kinda don't want to do this because it means we need two requests instead of one. But it might be the right long-term solution.

@ihabunek
Copy link
Owner

Oh, the fix is released in v.0.47.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants