-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@EMG70's YouTube playlist downloading problems 2024-06-10: (1) (This is taking longer than expected) (2) Metadata Fetch: [YouTube video URL] failed: 'NoneType' object cannot be interpreted as an integer [@avni results: (3) failed to download: None (4) it keeps trying to redownload failed videos] #178
Comments
Are these 2 other issues related — also with the
|
Please see the Python errors between Line 1082 and Line 1184 here:
|
Are these recent
Is this |
Now that both these PRs are merged... 💯
...where do we stand, helping @EMG70 move forward here?⚡ |
New VM installed after merging of PRs #179 and #180 SUDO IIAB-DIAGNOSTICS - https://dpaste.com/4U8T9242B I have attempted to download exactly same videos that failed on 10 /06/24.There is a huge improvement on most of them.Please see screenshots. |
Testing June 11, 2024. YouTube Playlist Part 1iiab-diagnostics: https://dpaste.com/4RDY4S535
|
Testing June 11, 2024. YouTube Playlist Part 2[Updated] iiab-diagnostics: https://dpaste.com/4RDY4S535
|
Testing June 11, 2024. YouTube Playlist Part 3[Updated] iiab-diagnostics: https://dpaste.com/GRX3DRTYX
|
Testing June 11, 2024. YouTube Playlist Part 4iiab-diagnostics: https://dpaste.com/CW6GJTBBZ
|
⬆️ @deldesir do you agree? |
I agree with this observation,the system seems to retry a previously failed video. |
I am pretty sure |
xklb does retry failed downloads, but Calibre-Web no. We don't have this implemented yet but will eventually. |
🧩 Possible background: (for others!) |
If you look at the screenshots I posted, the same YouTube file fails multiple times implying that failed files are being retried automatically. Do you know why that is? |
@avni what happened is this specific video started to download but stopped due to unavailable fragments. This downloads process left residual fragments that are used each time you try to download again. If you remove the video downloads directory and try again, the download will process from start but will be stuck at some point leaving incomplete file again. You wouldn't see any error message because xklb will not report one at this point, thus the "None" retrieved from database. This is an issue I was trying to address in #157 because each failed video must be accompanied with an error message explaining what happened. |
@deldesir fascinating. I don't know the inner workings of the system but am curious to understand more. For example, is there a downloads file for each video you download or just one for all downloads. If the latter, I wonder if you can just remove those fragments from the downloads directory for any files that fail. Very cool you are diving deep into this in #157. Thank you for the thorough explanation. 🙏 |
It's the latter. I'll resume work on it ASAP. |
Awesome. And Advance Apologies to everyone — that bug fixes are urgent yes — but take time to be architected properly ✊ |
SUDO IIAB-DIAGNOSTICS : https://dpaste.com/D9HL627NJ⚠️ 5/6 videos downloaded OK.Failed video's response "This is taking longer than expected"
The following were tested with varying results.
https://www.youtube.com/playlist?list=PLfiHW0cuXSvSiVuHqtO4IXMqWSrHou77B
This failed video https://www.youtube.com/watch?v=7qiwh4ybglo was tried individually and failed with "object cannot be interpreted as integer"
https://www.youtube.com/playlist?list=PLfiHW0cuXSvQ0s-oNi2syJNAPTN8gt4oi ❌ playlist of 29 videos failed
https://www.youtube.com/playlist?list=PLfiHW0cuXSvQSZHsA5zpo3JdrY5EJp1yT ❌
https://www.youtube.com/watch?v=iaQV0tehds4 ✅
https://www.youtube.com/playlist?list=PLbeRJIjdJ7QEuVxTNfQsPBpUv4UcQdAzJ ❌ short playlist with 3 videos failed.
Originally posted by @EMG70 in #172 (comment)
The text was updated successfully, but these errors were encountered: