-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video download intermittently fails: "A transaction is already begun on this Session." [when testing PR #244 & 7 PRs] #271
Comments
@deldesir can you copy/paste all relevant sections from above pastebins, onto this ticket please? (So important diagnostic material is more visible, more organized, and... is not lost!) |
IIAB diagnostics
Calibre-Web log
|
Metadata fetch task fails after a certain period of inactivity (9:24...09:43)
|
@deldesir Which commits/PRs fixes this? Can you reference them here if applicable? |
List of commits that close sessions that stayed open:
|
I tested the additions on Ubuntu 24.04. I consider them as the fix for this issue. Next steps would be to merge them as part of the PRs outlined in the above message which transition to SQLAlchemy..., or to discard them in favor of the current pure SQL implementation. @EMG70 can you confirm with a test on your side if possible? |
I am on it now.I Will update you soon. |
A new 24.04 VM was created and tests done without errors. |
A fresh size 1 IIAB was installed on a PI400 and video download tested without errors. |
Thanks. Please also do some search and download several videos at various intervals (13-15 mins between downloads). |
Ok I will do. |
Great. We can always re-open it if absolutely necessary. |
Thank you @deldesir, I'm trying to replicate the issue to test the patches and I can't reproduce the error (prior to applying the patches)!I tried different tabs, leaving a tab open, waiting a few minutes and coming back, and no luck. Do you know the specific steps that would reproduce the issue? |
The patches are applied in their relevant PRs and the issue is no longer reproducible, sorry. |
I'm a bit confused. I have an older version of IIAB that hasn't been upgraded since 10/24. It has an older version of the patches applied which originally surfaced the issue when @deldesir and I were testing live. It doesn't (I don't think) have the latest patches that fixed the session opened issue. Is there a quick way I can test if the patch to fix this issue is applied or not? A specific code change I can look for? Thanks! |
In this case, I would suggest to:
The error should kick in and be displayed in the Tasks page, triggered by an open database session. |
Description of bug
Video download fails initially with error, "A transaction is already begun on this Session". Subsequent downloads of same video are successful.
To Reproduce
Steps to reproduce the behavior:
Logs
Expected behavior
I expect the video download to succeed on the initial attempt.
Screenshots
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: