New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on the fly unzip for modules #374

Open

tim-moody opened this issue Nov 23, 2020 · 2 comments

Contributor

tim-moody commented Nov 23, 2020 •

edited

Loading

https://xxx.zip | busybox unzip - -d moddir will unzip on the fly to moddir

Contributor

georgejhunt commented Nov 24, 2020

Will there be a precedence for zip vs rsync? If "curl https:xxx.zip | busybox -d moddir" fails, then try rsync? Or will you assume that if there is a {rsync_url,zip_url} value present, it will be valid.

Up til now, we have tested the rsync approach. We don't know how many zip_http_url links are broken. I guess we should use the rsync tested link if present.

Contributor Author

tim-moody commented Nov 24, 2020

I think we need to explore to make sure the on the fly zip works.

I'd like to assume the links are valid. errors get trapped and reported in cmdsrv. if it gets out of hand then more checking can be done. there could also be an admin console setting to prefer one over the other, but that takes a new ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment