From 80529e1ac610e8e0024fbfa2ac084f4ad00b7ded Mon Sep 17 00:00:00 2001 From: Raphael van Kempen Date: Sun, 25 Feb 2024 00:06:04 +0100 Subject: [PATCH 1/4] image-name to lower-cse --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 01b95ea..eff71e5 100644 --- a/action.yml +++ b/action.yml @@ -19,7 +19,7 @@ inputs: image-name: description: "Image name of run image" - default: ghcr.io/${{ github.repository }} + default: ghcr.io/${{ lower(github.repository) }} image-tag: description: "Image tag of run image" From acc05ef31427212a02764f9ead102b49feb3acf2 Mon Sep 17 00:00:00 2001 From: Raphael van Kempen Date: Sun, 25 Feb 2024 00:16:47 +0100 Subject: [PATCH 2/4] enforce lower-case image name --- action.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index eff71e5..6f6e39d 100644 --- a/action.yml +++ b/action.yml @@ -172,6 +172,12 @@ runs: - name: Set up Docker buildx uses: docker/setup-buildx-action@v3 + - name: Enforce lower-case image name + id: image-name + uses: ASzc/change-string-case-action@v6 + with: + string: ${{ inputs.image-name }} + - name: Build images id: build-images shell: bash @@ -182,7 +188,7 @@ runs: TARGET: ${{ inputs.target }} BASE_IMAGE: ${{ inputs.base-image }} COMMAND: ${{ inputs.command }} - IMAGE_NAME: ${{ inputs.image-name }} + IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }} IMAGE_TAG: ${{ inputs.image-tag }} DEV_IMAGE_NAME: ${{ inputs.dev-image-name }} DEV_IMAGE_TAG: ${{ inputs.dev-image-tag }} @@ -239,7 +245,7 @@ runs: TARGET: ${{ inputs.target }} BASE_IMAGE: ${{ inputs.base-image }} COMMAND: ${{ inputs.command }} - IMAGE_NAME: ${{ inputs.image-name }} + IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }} IMAGE_TAG: ${{ inputs.image-tag }} DEV_IMAGE_NAME: ${{ inputs.dev-image-name }} DEV_IMAGE_TAG: ${{ inputs.dev-image-tag }} @@ -275,7 +281,7 @@ runs: TARGET: ${{ inputs.target }} BASE_IMAGE: ${{ inputs.base-image }} COMMAND: ${{ inputs.command }} - IMAGE_NAME: ${{ inputs.image-name }} + IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }} IMAGE_TAG: latest DEV_IMAGE_NAME: ${{ inputs.dev-image-name }} DEV_IMAGE_TAG: latest-dev From 65df7bac30d393fc18303508f3770157ca489a3f Mon Sep 17 00:00:00 2001 From: Raphael van Kempen Date: Sun, 25 Feb 2024 00:18:13 +0100 Subject: [PATCH 3/4] remove lower --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 6f6e39d..ecb37a3 100644 --- a/action.yml +++ b/action.yml @@ -19,7 +19,7 @@ inputs: image-name: description: "Image name of run image" - default: ghcr.io/${{ lower(github.repository) }} + default: ghcr.io/${{ github.repository }} image-tag: description: "Image tag of run image" From 75fff1837c1145ec979eea9024f504e95a29b72d Mon Sep 17 00:00:00 2001 From: Raphael van Kempen Date: Tue, 26 Mar 2024 09:55:07 +0100 Subject: [PATCH 4/4] enforce lower-case dev image name --- action.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/action.yml b/action.yml index ecb37a3..6dbbd89 100644 --- a/action.yml +++ b/action.yml @@ -178,6 +178,12 @@ runs: with: string: ${{ inputs.image-name }} + - name: Enforce lower-case dev image name + id: dev-image-name + uses: ASzc/change-string-case-action@v6 + with: + string: ${{ inputs.dev-image-name }} + - name: Build images id: build-images shell: bash @@ -190,7 +196,7 @@ runs: COMMAND: ${{ inputs.command }} IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }} IMAGE_TAG: ${{ inputs.image-tag }} - DEV_IMAGE_NAME: ${{ inputs.dev-image-name }} + DEV_IMAGE_NAME: ${{ steps.dev-image-name.outputs.lowercase }} DEV_IMAGE_TAG: ${{ inputs.dev-image-tag }} RMW_IMPLEMENTATION: ${{ inputs.rmw-implementation }} ROS_DISTRO: ${{ inputs.ros-distro }}