Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] LED Brightness and Sound Toggle #87

Open
garv3 opened this issue May 21, 2022 · 6 comments
Open

[feature request] LED Brightness and Sound Toggle #87

garv3 opened this issue May 21, 2022 · 6 comments

Comments

@garv3
Copy link

garv3 commented May 21, 2022

It would be awesome to be able to set the LED brightness instead of just setting it to 0% or 100%.
Additionally it would be great to have a toggle for sounds (called 'buzzer' on smartmi fans).

@Olegz73
Copy link

Olegz73 commented May 22, 2022

+1 it will be good to add buzzer button and night mode button to model dmaker.fan.p9
and if may add on\off button when animation is off

@garv3
Copy link
Author

garv3 commented May 23, 2022

I added the buzzer and an ionizer button in my pull request #90
@ikaruswill Please pull it to the repo.

@garv3
Copy link
Author

garv3 commented May 23, 2022

LED brightness is now also included in the pull request #90

@ikaruswill
Copy link
Owner

Thanks for your work. That's quite a big MR. Let me take some time to review.

Tbh, we actually also have an active branch to switch to the boilerplate-card structure and I'd like to merge that first so that we get a standardized codebase as soon as possible. I'll have to first see how your changes fit in with the branch's code, so it might take some time.

Branch: https://github.com/ikaruswill/lovelace-fan-xiaomi/tree/boilerplate-card

@garv3
Copy link
Author

garv3 commented May 23, 2022

There are not too many real changes. It appears to be a lot bigger than it is because there are many changes made to indentations by Visual Studio. The actual changes are just a few lines and I tried to stick to the previous code where possible.

@ikaruswill
Copy link
Owner

👍 was intimidated by the green lines as I was scrolling them on mobile on the bed lol. Will check it out in detail when I get back on desktop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants