-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] LED Brightness and Sound Toggle #87
Comments
+1 it will be good to add buzzer button and night mode button to model dmaker.fan.p9 |
I added the buzzer and an ionizer button in my pull request #90 |
LED brightness is now also included in the pull request #90 |
Thanks for your work. That's quite a big MR. Let me take some time to review. Tbh, we actually also have an active branch to switch to the Branch: https://github.com/ikaruswill/lovelace-fan-xiaomi/tree/boilerplate-card |
There are not too many real changes. It appears to be a lot bigger than it is because there are many changes made to indentations by Visual Studio. The actual changes are just a few lines and I tried to stick to the previous code where possible. |
👍 was intimidated by the green lines as I was scrolling them on mobile on the bed lol. Will check it out in detail when I get back on desktop! |
It would be awesome to be able to set the LED brightness instead of just setting it to 0% or 100%.
Additionally it would be great to have a toggle for sounds (called 'buzzer' on smartmi fans).
The text was updated successfully, but these errors were encountered: