-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPM versions of UniRecast and DotRecast #1
Comments
Hello, @Danil0v3s Firstly, I agree with the suggestion of UPM projectization. Offering the project as a package can significantly enhance user accessibility. However, I'd like to seek clarification on the rationale behind separating DotRecast and UniRecast into individual UPMs. I have a few inquiries in this regard. Could you provide insights into the considerations behind splitting DotRecast and UniRecast? I'm curious if this decision is based on factors such as modularization, dependency management, maintenance, updates, or user convenience. It would be great if you could share your insights on this matter. A more detailed explanation of this decision would be beneficial for our discussion. |
I'm glad you liked! The reason I chose to split these two is because they're indeed two different projects and DotRecast is a dependency of UniRecast. I couldn't add DotRecast directly as a dependency of UniRecast because I don't have it published in any package registry, I'm also not sure whether Unity supports other registries other than their own. The way I see it is UniRecast is a tool built on top of DotRecast and their lifecycle is different, therefore they should live in different repositories. Updating each package should be easy enough once they're on the UPM and as long as we publish the versions correctly to the package.json file |
Thank you for your advice. I am currently exploring various aspects of Unity Package Manager (UPM). https://repo.git Which approach is more developer-friendly? I am currently referencing the UniTask project. |
My personal opinion regarding the URLs would be the middle one
Since you're referencing UniTask, that one would also need to be on a registry if we wanted to keep our projects in a registry. But since they're not currently in a registry, if you reference their |
Summing up, the most favorable scenario appears to be offering it in the repo.git format. Additionally, DotRecast will be integrated into UniRecast rather than being provided separately through UPM. The reasons for this decision are as follows:
If you have any concerns, please feel free to let me know. I will review and consider them. |
Could you submit a pull request for the UniRecast UPM that has been worked on? |
@Danil0v3s |
Hey, been lurking around and trying to get things working for a while and been wondering if we should make both UniRecast and DotRecast a UPM package.
For that matter, I've prepared a fork of each repo and created a new branch with the UPM structure. You can view them at
One can add both dependencies to their project using the Unity Package Manager with the following pattern: [repo url].git#unity and it will target the
unity
branch with the correct structure. I've taken the time to make sure the Assembly Definitions are created and point to the correct places.For development purposes, you can create a folder with the package name inside the ProjectFolder/Packages dir, for instance,
com.defnotagamestudio.unirecast
and develop normally. Unity will detect that folder as a local lib.What do you think?
The text was updated successfully, but these errors were encountered: